Skip to content

Update instagram_pic.py #10957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 29, 2023
Merged

Update instagram_pic.py #10957

merged 20 commits into from
Oct 29, 2023

Conversation

nababuddin
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@nababuddin nababuddin requested a review from cclauss as a code owner October 25, 2023 17:11
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 25, 2023
nababuddin

This comment was marked as outdated.

Sign in to view

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 25, 2023
nababuddin
nababuddin commented Oct 25, 2023
View reviewed changes
Copy link
Contributor Author

@nababuddin nababuddin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Please

nababuddin
nababuddin commented Oct 25, 2023
View reviewed changes
Copy link
Contributor Author

@nababuddin nababuddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issues

cclauss
cclauss reviewed Oct 28, 2023
View reviewed changes
web_programming/instagram_pic.py Outdated
Comment on lines 23 to 31
print(f"Image downloaded and saved as {file_name}")
else:
print("Failed to download the image.")
else:
print("Image URL not found in the meta tag.")
else:
print("No meta tag with 'og:image' property found.")
except requests.exceptions.RequestException as e:
print(f"An error occurred during the HTTP request: {e}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md: Algorithmic functions should not print().

cclauss
cclauss reviewed Oct 29, 2023
View reviewed changes
web_programming/instagram_pic.py Outdated
@@ -1,37 +1,68 @@
from datetime import datetime
from typing import Optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed on Python 3.12

Suggested change
from typing import Optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss tried many times but every time getting this error
Error: web_programming/instagram_pic.py:1:1: I001 Import block is un-sorted or un-formatted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the imports were working fine before, then do not change them.

Click the text I001 to read the rule and how it works.

python3 -m pip install ruff and then ruff --select=I --fix web_programming/instagram_pic.py

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 29, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 29, 2023
@cclauss cclauss merged commit adb13a1 into TheAlgorithms:master Oct 29, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@nababuddin @pre-commit-ci
@cclauss @sedatguzelsemme
Update instagram_pic.py (TheAlgorithms#10957)
8f6d0d7 
* Update instagram_pic.py

* Update instagram_pic.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update instagram_pic.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update instagram_pic.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update instagram_pic.py

* Update instagram_pic.py

* Update instagram_pic.py

* Update instagram_pic.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update instagram_pic.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update instagram_pic.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update instagram_pic.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fast fail instead of nested ifs and PEP8: Keep try/except blocks small

* Update instagram_pic.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nababuddin @cclauss